[docs] Fix broken vldb23.pdf link - #6800
Merged
Merged
Conversation
Docusaurus rewrites root-absolute links to static files into content-hashed asset paths, and trailingSlash:true then appends a trailing slash after the .pdf extension, producing a 404 (/assets/files/vldb23-<hash>.pdf/). Use the pathname: protocol, the convention already used elsewhere in these docs for raw file links, so Docusaurus leaves the URL untouched. Found via the docs-linkcheck CI job. Signed-off-by: Ben Pfaff <blp@feldera.com>
mihaibudiu
approved these changes
Aug 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 4, 2026
mythical-fred
approved these changes
Aug 4, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
APPROVE.
Correct fix. Docusaurus with trailingSlash: true rewrites root-absolute static-file links into content-hashed asset paths and then appends a slash after the extension, so a bare /vldb23.pdf link ends up as …/vldb23-<hash>.pdf/ and 404s. The pathname: protocol tells Docusaurus to leave the URL alone, which is the convention already used elsewhere in these docs and is exactly the right escape hatch here. Two-line fix, caught by the linkcheck CI job — good hygiene.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docusaurus rewrites root-absolute links to static files into content-hashed asset paths, and trailingSlash:true then appends a trailing slash after the .pdf extension, producing a 404 (/assets/files/vldb23-.pdf/). Use the pathname: protocol, the convention already used elsewhere in these docs for raw file links, so Docusaurus leaves the URL untouched.
Found via the docs-linkcheck CI job.