Re-enable test_jsonbench.py - #6773
Merged
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
gz
approved these changes
Jul 30, 2026
mihaibudiu
enabled auto-merge
July 30, 2026 18:16
Contributor
|
you can control this also editing the github variable, no need to do a commit |
mythical-fred
approved these changes
Jul 30, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Straightforward rename to re-enable the previously disabled jsonbench test. CI will be the judge — if it times out again (issue #6709 noted two ~1h timeouts), we'll need to actually address the perf/timeout issue rather than just re-enabling. But worth a shot given recent CI improvements. Clean commit message with DCO trailer.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
Member
|
@mihaibudiu The test failed |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6709
Let's see if the test passes after the recent improvements in CI.