Medallion Demo SQL Formatting - #6768
Merged
Merged
Conversation
mihaibudiu
approved these changes
Jul 30, 2026
Formatted medallion demo sql and removed a lengthy but unncessary comment. Added .env to gitignore Signed-off-by: Anand Raman <anand.raman@feldera.com>
anandbraman
force-pushed
the
medallion-demo-comment
branch
from
July 30, 2026 15:06
c40a9e3 to
5ded806
Compare
anandbraman
enabled auto-merge
July 30, 2026 15:06
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
mythical-fred
approved these changes
Jul 30, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM.
One soft nit, take it or leave it: the removed comment in sql/01-medallion-architecture.sql around avg_daily_units was doing real work — it explained why the denominator is COUNT(DISTINCT DATE_TRUNC(order_created_at, DAY)) rather than a hard-coded 30, and why the more obvious WHERE order_created_at > NOW() - INTERVAL '30' DAY alternative was rejected for this demo. That reasoning is not recoverable from the SQL itself. If it feels too verbose inline, a two-line "// per-day rate over the observed span, not a fixed 30-day window" version keeps the intent without the wall of text. Non-blocking.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatted medallion demo sql and removed a lengthy but unncessary comment. Added .env to gitignore
Describe Manual Test Plan
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes