[profiler] Search by table/view name - #6764
Conversation
…ngs) Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
left a comment
There was a problem hiding this comment.
Clean profiler feature: search now matches table/view names in addition to node IDs and persistent-ID substrings, and reveals hidden matches by expanding their collapsed ancestors before centering on the next layout.
Nice touches:
CircuitProfile.byNameis populated from the dataflow's MIR pass and keyed lowercase;findByNameprefers an exact match over a substring match, which is the right precedence for named tables that happen to be substrings of view names (theport/reporttest pins this).ComplexNode.collapsedOperation()cleanly separates the collapsed label (operation + contained names) from the expanded label;Cytographonly calls it when a node is drawn as a cluster, so the semantic split is enforced structurally rather than by convention.- The previous fallback that walked to the outermost parent and toggled it was blunt;
CircuitSelector.expandAncestorsexpands only the collapsed ancestors that actually hide the target, andVisualizer.reveal()clearscenterOnNextLayoutwhen nothing was expanded so an unrelated later layout does not surprise the user. - Tests cover name indexing, substring fallback, exact-over-substring precedence, and ancestor propagation of contained names.
Second commit is trivial: names all connectors entries in the medallion demo and fixes the pipelie_sources → pipeline_sources typo in sec-ops. Both silence warnings without behavior change.
CI is green. No AI trailers.
One minor observation, non-blocking: findByName's substring fallback iterates byName.entries() in insertion order, so with multiple substring matches the earliest-inserted wins. That is deterministic given a fixed dataflow, but the ordering is not part of the documented contract — worth a note if a user ever asks "why did it pick this one?".
Approving.
Karakatiza666
left a comment
There was a problem hiding this comment.
LGTM. Did you find node indexes for the purposes of the search benefitial?
Fixes #6762
A second commit adds names to connectors in a demo to silence warnings.
Checklist
I have tested this manually locally.