[DBSP] Remove add_input_set API and related helpers - #6759
Conversation
d23329f to
0446c3e
Compare
0446c3e to
01e058e
Compare
mythical-fred
left a comment
There was a problem hiding this comment.
The benchmark in crates/dbsp/benches/ldbc-graphalytics/main.rs (line 169) still calls circuit.dyn_add_input_set(), which this PR removes. This will break compilation of the benchmark after merge. Please update or remove that call.
|
The ldbc benchmark is actually commented-out |
|
You're right, my mistake — I missed that |
mythical-fred
left a comment
There was a problem hiding this comment.
Clean removal of add_input_set, SetHandle, DeSetHandle, update_set, and UpdateSetFactories. The remaining dyn_add_input_set reference in benches/ldbc-graphalytics/main.rs isn't a build hazard — that file isn't declared as a [[bench]] target and doesn't get compiled. Approving.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
01e058e to
fdad3af
Compare
Fixes #6757