adapters: serialize Avro timestamptz as timestamp-micros - #6718
Merged
Conversation
ryzhyk
approved these changes
Jul 24, 2026
mythical-fred
approved these changes
Jul 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Straightforward: timestamp_tz_format was left at the default in the Avro serde config, so timestamptz columns weren't serialized as timestamp-micros. Explicit setter on SqlSerdeConfig + a targeted round-trip test.
APPROVE.
Contributor
Author
|
just realized same fix was made in #6619 |
Contributor
|
Yes, but this PR was reviewed, and the other wasn't... |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 26, 2026
Contributor
|
Can you please fix these conflicts? |
ryzhyk
force-pushed
the
shuang/avro-timestamptz
branch
from
July 28, 2026 05:18
7f57ef5 to
87bf440
Compare
ryzhyk
enabled auto-merge
July 28, 2026 05:19
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timestamptzwas using default string serialization, but should be using avro'stimestamp-micros, which is also the avro datatype feldera generates fortimestamptztypes