Skip to content

[SQL] support MATERIALIZED table and views - #1959

Merged
ryzhyk merged 7 commits into
mainfrom
materialized
Jun 29, 2024
Merged

[SQL] support MATERIALIZED table and views#1959
ryzhyk merged 7 commits into
mainfrom
materialized

Conversation

@mihaibudiu

@mihaibudiu mihaibudiu commented Jun 27, 2024 •
edited by ryzhyk
Loading

Copy link
Copy Markdown
Contributor

Remaining tasks:

  • Materialization strategy for tables
  • WebConsole update: grey out the VIEW button for non-materialized tables and views (@Karakatiza666)
  • Update demos, making a subset of tables/views MATERIALIZED
  • Update docs

Is this a user-visible change (yes/no): yes

Addresses #1920

@mihaibudiu
mihaibudiu requested a review from ryzhyk June 27, 2024 00:26
@ryzhyk
ryzhyk marked this pull request as draft June 27, 2024 07:11
mihaibudiu
mihaibudiu commented Jun 27, 2024
View reviewed changes

@mihaibudiu mihaibudiu left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@ryzhyk

ryzhyk commented Jun 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Karakatiza666 , required WebConsole changes:

  • To determine whether a table or view is materialized, use the materialized attribute in the JSON schema.
  • For non-materialized tables and views, grey-out the eye icons and the BROWSE tab.
    • When hovering over the greyed-out view, display the following hint: "Use 'CREATE MATERIALIZED VIEW' syntax to enable browsing the view".
    • When hovering over the greyed-out table, display the following hint: "Use 'CREATE TABLE (..) WITH ('materialized'='true')' syntax to enable browsing the table".

@ryzhyk ryzhyk changed the title [SQL] support MATERIALIZED views [SQL] support MATERIALIZED table and views Jun 27, 2024
@ryzhyk ryzhyk linked an issue Jun 28, 2024 that may be closed by this pull request
GC output traces. #1920
Closed
@Karakatiza666

Karakatiza666 commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

image
image

@ryzhyk
ryzhyk force-pushed the materialized branch 2 times, most recently from 7fbb268 to c26465a Compare June 28, 2024 20:52
@ryzhyk
ryzhyk marked this pull request as ready for review June 28, 2024 21:11
@ryzhyk
ryzhyk marked this pull request as draft June 28, 2024 22:08
Leonid Ryzhyk and others added 7 commits June 28, 2024 20:04
Leonid Ryzhyk @mihaibudiu
Support materialized views in the catalog API.
a0d01b3 
Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
@mihaibudiu
[SQL] support MATERIALIZED views and tables.
8fdfa92 
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Leonid Ryzhyk @mihaibudiu
Materialized view-related fixups.
3ea42e7 
- Docs
- Demos
- Python API

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
@Karakatiza666 @mihaibudiu
WebConsole: disable browsing data for non-materialized relations
e5401cf 
Update API typings

Signed-off-by: George <bulakh.96@gmail.com>
Leonid Ryzhyk @mihaibudiu
Doc section on materialized views.
bb2191d 
Add a section on materialized tables and views in SQL compiler docs.

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Leonid Ryzhyk @mihaibudiu
integration_test: Output compilation status.
137ad1a 
Print compilation status to help debug compilation timeouts.

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
@mihaibudiu
Rebase on main
e559387 
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@ryzhyk
ryzhyk marked this pull request as ready for review June 29, 2024 05:14
@ryzhyk
ryzhyk merged commit 21f44e1 into main Jun 29, 2024
@ryzhyk
ryzhyk deleted the materialized branch June 29, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryzhyk ryzhyk ryzhyk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GC output traces.

3 participants

@mihaibudiu @ryzhyk @Karakatiza666