Skip to content

Dove Support - #368

Closed
forgot wants to merge 10 commits into
feathersjs-ecosystem:masterfrom
forgot:Dove
Closed

Dove Support#368
forgot wants to merge 10 commits into
feathersjs-ecosystem:masterfrom
forgot:Dove

Conversation

@forgot

@forgot forgot commented Apr 28, 2021 •
edited
Loading

Copy link
Copy Markdown
  • Tell us about the problem your pull request is solving.
    Updates @feathersjs dependencies to ^5.0.0-pre.3 to work with Dove
  • Are there any open issues that are related to this?
    Not that I could find
  • Is this PR dependent on PRs in other repos?
    Nope!

This pull request primarily updates the type expectations to match Dove. It would obviously be better for this to remain it's own branch and did not merge with master, but there is not currently a Dove branch.

All tests pass with npm test

@daffl

daffl commented May 12, 2021

Copy link
Copy Markdown
Member

Great, thank you for doing that! I'm wondering if I should move the Paginated type back into the main repo if that is the only breaking change (which it looks like it is).

@forgot

forgot commented May 13, 2021

Copy link
Copy Markdown
Author

I'm happy to pull the changes in if you do. Out of curiosity, what was the reason for moving it in the first place?

@daffl daffl mentioned this pull request May 13, 2021
Merged
@daffl

daffl commented May 13, 2021

Copy link
Copy Markdown
Member

Well, the type isn't really something a core Feathers service expects or uses, it's only a convention used by the adapters. I just published 5.0.0-pre.4 changing it back. I think most things should now be backwards compatible but it'd probably be good to pass the new generic types along so you can initialize the adapter service with data and return types other than any.

@forgot

forgot commented May 15, 2021

Copy link
Copy Markdown
Author

I've bumped everything to 5.0.0-pre.4 and moved the Paginated import back. All tests are still passing.

@forgot

forgot commented Aug 25, 2021

Copy link
Copy Markdown
Author

I've bumped everything to 5.0.0-pre.9, and all tests are still passing.

@daffl

daffl commented Aug 25, 2021

Copy link
Copy Markdown
Member

This is good to know. At least updating the adapters (other than infrastructure) should be doable then. I had to make a bunch of dud pre-releases because the publish was broken so I didn't expect too much to change.

forgot added 3 commits February 6, 2022 21:36
@forgot
Merge branch 'master' into Dove
e54b8b1 
# Conflicts:
#	package-lock.json
#	package.json
@forgot
Removed deprecated Sequelize option
85114fe 
Per deprecation warning: "A boolean value was passed to options.operatorsAliases. This is a no-op with v5 and should be removed."
@forgot
Updated @feathersjs dependencies to ^5.0.0-pre.16;
0c380d8 
All tests passing
@forgot

forgot commented Feb 7, 2022

Copy link
Copy Markdown
Author

I've bumped everything to 5.0.0-pre.16, and all tests are still passing.

@fratzinger fratzinger mentioned this pull request Oct 2, 2022
Merged
@fratzinger

fratzinger commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

merged via #400 into master. feathers-sequelize@7.0.0 released with dove support.
Thanks for kicking this off!

@fratzinger fratzinger closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mrhegemon mrhegemon mrhegemon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@forgot @daffl @fratzinger @mrhegemon