You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See #363. I consider this quite hacky but it would solve my problem with multi-patch for a length of items > 10 for now. I would prefer to get this added to @feathersjs/adapter-tests and @feathersjs/adapter-commons (see issue #363) but wait the opinion of others on this.
I have mixed feelings about this, too. I know scenarios where this definitely is a breaking change.
My scenario is:
On multi patch, use a before-hook with find (not explicitely not _find) with the exact same params to determine which records will be affected for some reasons. So find and patch/remove have to return the exact same records.
This is a reason against automatic paginate: false in patch (as suggested in this PR), because find by default would return max. 10 records and patch would return all records.
My current way to go is an early app.hooks.ts-before-hook for patch/remove that sets paginate: false if it's not set. This way my scenario works because it returns the same for find and patch.
That being said. I think this behavior should be the same for all 'major' adapters. I will see if I can come up with a test in @feathersjs/adapter-tests that can used in all adapters. When we have that and are clear that all adapters act the same, I think, we should add a note to the feathers.js main docs as a Important or Note quote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #363. I consider this quite hacky but it would solve my problem with multi-patch for a length of items > 10 for now. I would prefer to get this added to
@feathersjs/adapter-testsand@feathersjs/adapter-commons(see issue #363) but wait the opinion of others on this.