feat: new util stringifyParams#44
Merged
Merged
Conversation
Deploying feathers-utils with
|
| Latest commit: |
5ebecdb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c41aa884.feathers-utils.pages.dev |
| Branch Preview URL: | https://feat-new-util-stringify-para.feathers-utils.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new utility functions to the
src/commondirectory, improves test organization, and refactors the cache hook to use a safer and more robust parameter stringification strategy. It also updates documentation and dependency management to reflect these changes.New utility functions and testing improvements:
hasOwnProperty,toArray,early, andisPlainObjectinsrc/common, each with in-source Vitest tests for improved maintainability and coverage. [1] [2] [3] [4]cloneutility's tests into in-source Vitest blocks and removed the separate test file, streamlining test code and reducing file clutter. [1] [2]Cache hook improvements:
stableStringifyfunction with the newstringifyParamsutility (which usessafe-stable-stringify) for serializing cache keys, making cache key generation crash-safe and more robust to edge cases like circular references and non-JSON values. Updated documentation and type hints accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Internal codebase refactoring:
toArrayfrominternal.utilsto now import it from the newcommonlocation, reflecting its promotion to a public utility. [1] [2] [3] [4]Documentation and dependency updates:
CLAUDE.mdfile detailing the project's structure, conventions, and commands, providing clear guidance for contributors.safe-stable-stringifydependency and updatedpnpm-lock.yamlaccordingly. [1] [2] [3] [4]These changes improve utility discoverability, make the codebase more robust and maintainable, and enhance documentation for current and future contributors.