add methodQuery parameter for patch and update - #181

There was a recent addition to feathers-sequelize that handled this problem by creating a better findParams. I will take a look at this tomorrow and see if the same solution works.

The problem is similar to that tackled in feathers-sequelize. The updateMany method does not return the documents that were updated. The original query cannot be used in the subsequent findOrGet because the query parameters have changed. In order to fix this, I think we need to do something similar where we get the idList of the documents that are about to change and then apply that to the query that re-fetches the documents. See: https://github.com/feathersjs-ecosystem/feathers-sequelize/blob/1bcfe9f394b619fdad66b956b6df9f6bcd963a8a/lib/index.js#L225

The problem is similar to that tackled in feathers-sequelize. The updateMany method does not return the documents that were updated. The original query cannot be used in the subsequent findOrGet because the query parameters have changed. In order to fix this, I think we need to do something similar where we get the idList of the documents that are about to change and then apply that to the query that re-fetches the documents. See: https://github.com/feathersjs-ecosystem/feathers-sequelize/blob/1bcfe9f394b619fdad66b956b6df9f6bcd963a8a/lib/index.js#L225

Ok, I'm going to change this PR along these lines then.

@sechel any updates on this? Experiencing this with SoftDelete as well.

@ecirish I believe this was fixed with feathersjs-ecosystem/feathers-mongoose#330
The patch method should return the patched records correctly.

Which softDelete are you using?

@DaddyWarbucks I'm using the latest SoftDelete from feathers-hooks-common, but I'm not using Mongoose. Just feathers-mongodb.

Oh! Whoops, my bad! I got the adapter repos crossed. From the looks of https://github.com/feathersjs-ecosystem/feathers-mongodb/blob/6bf168269f7cbb9f329cc8a530d5ee7677b645f7/lib/index.js#L215 this is still a bug here in this adapter. I will try to make some time tomorrow to fix this. I fixed similar issues in Mongoose and Sequelize, so this should be pretty straightforward.

@DaddyWarbucks Wow. Thanks for the prompt reply and the even more impressive prompt action!

@sechel any updates on this? Experiencing this with SoftDelete as well.

I also had issues with softDelete that led me to this PR. Great that @DaddyWarbucks is looking into this as I have not the time to do so right now.

Thank you for the pull request! This has now been fixed via #188