Skip to content

refactor(schema): init typebox schema - #2762

Closed
fratzinger wants to merge 1 commit into
feathersjs:dovefrom
fratzinger:dove-schema-typebox
Closed

refactor(schema): init typebox schema#2762
fratzinger wants to merge 1 commit into
feathersjs:dovefrom
fratzinger:dove-schema-typebox

Conversation

@fratzinger

@fratzinger fratzinger commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@fratzinger
fratzinger requested a review from daffl September 26, 2022 16:02
@fratzinger fratzinger mentioned this pull request Sep 26, 2022
Closed
@noor-tg

noor-tg commented Sep 29, 2022

Copy link
Copy Markdown

would you describe the details about this change ?

@fratzinger

fratzinger commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

Sorry for the confusion! This PR is about tinkering. It's something @daffl and I have discussed.
We want to see if Typebox could be a way to define the new JSON schemas in feathers v5. I've tried it in the feathers-chat repo and wanted to share it with @daffl, so he can elaborate if there's a fit for feathers.js.

How come you're interested in this PR @Nour-DEV? I'm interested in your thoughts.

@noor-tg

noor-tg commented Sep 29, 2022

Copy link
Copy Markdown

Sorry for the confusion! This PR is about tinkering. It's something @daffl and I have discussed.
We want to see if Typebox could be a way to define the new JSON schemas in feathers v5. I've tried it in the feathers-chat repo and wanted to share it with @daffl, so he can elaborate if there's a fit for feathers.js.

How come you're interested in this PR @Nour-DEV? I'm interested in your thoughts.

I don't know the context of the pull request . So I asked about the details. So I can't evaluate it.

@daffl daffl mentioned this pull request Oct 3, 2022
Merged
@daffl daffl closed this in #2772 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daffl daffl Awaiting requested review from daffl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fratzinger @noor-tg