Skip to content

Replace "xlink:href" with "href" - #1070

Merged
colebemis merged 1 commit into
feathericons:masterfrom
micka-fdz:patch-1
Sep 22, 2021
Merged

Replace "xlink:href" with "href"#1070
colebemis merged 1 commit into
feathericons:masterfrom
micka-fdz:patch-1

Conversation

@micka-fdz

Copy link
Copy Markdown
Contributor

As mentioned in this documentation, xlink:href attribute is now deprecated.

SVG 2 removed the need for the xlink namespace, so instead of xlink:href you should use href.

@codecov

codecov Bot commented Apr 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1070 (448becb) into master (a718a7e) will not change coverage.
The diff coverage is n/a.

❗ Current head 448becb differs from pull request most recent head d1db98b. Consider uploading reports for the commit d1db98b to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1070   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a718a7e...d1db98b. Read the comment docs.

@micka-fdz

micka-fdz commented Apr 12, 2021

Copy link
Copy Markdown
Contributor Author

Hi @colebemis. I don't understand previous Codecov Report. What should I do?

@colebemis colebemis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @micka-fdz! ❤️

@colebemis
colebemis merged commit 4d61ba7 into feathericons:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants