Skip to content

Commit 9ea21c6

Browse files
committed
Remove unnecessary function
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
1 parent 766157e commit 9ea21c6

4 files changed

Lines changed: 3 additions & 25 deletions

File tree

serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequestV2 re
156156
ValueProto.Value value =
157157
feature.getFeatureValue(featureValueTypes.get(feature.getFeatureReference()));
158158
Boolean isFound =
159-
feature.isSameFeatureSpec(featureValueTypes.get(feature.getFeatureReference()));
159+
Feature.TYPE_TO_VAL_CASE
160+
.get(featureValueTypes.get(feature.getFeatureReference()))
161+
.equals(value.getValCase());
160162

161163
Boolean isOutsideMaxAge =
162164
checkOutsideMaxAge(

storage/api/src/main/java/feast/storage/api/retriever/Feature.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,4 @@ public interface Feature {
4949
FeatureReferenceV2 getFeatureReference();
5050

5151
Timestamp getEventTimestamp();
52-
53-
Boolean isSameFeatureSpec(ValueProto.ValueType.Enum anEnum);
5452
}

storage/api/src/main/java/feast/storage/api/retriever/NativeFeature.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,6 @@ public ValueProto.Value getFeatureValue(ValueProto.ValueType.Enum valueType) {
7676
return finalValue;
7777
}
7878

79-
@Override
80-
public Boolean isSameFeatureSpec(ValueProto.ValueType.Enum valueType) {
81-
ValueProto.Value actualValue = getFeatureValue(valueType);
82-
83-
return TYPE_TO_VAL_CASE.get(valueType).equals(actualValue.getValCase());
84-
}
85-
8679
@Override
8780
public ServingAPIProto.FeatureReferenceV2 getFeatureReference() {
8881
return this.featureReference;

storage/api/src/main/java/feast/storage/api/retriever/ProtoFeature.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,6 @@ public ValueProto.Value getFeatureValue(ValueProto.ValueType.Enum valueType) {
4545
return this.featureValue;
4646
}
4747

48-
@Override
49-
public Boolean isSameFeatureSpec(ValueProto.ValueType.Enum valueType) {
50-
// Same feature reference, but different type
51-
if (valueType.equals(ValueProto.ValueType.Enum.INVALID)) {
52-
return false;
53-
}
54-
55-
// Same feature reference, but empty value
56-
if (this.featureValue.getValCase().equals(ValueProto.Value.ValCase.VAL_NOT_SET)) {
57-
return true;
58-
}
59-
60-
return TYPE_TO_VAL_CASE.get(valueType).equals(this.featureValue.getValCase());
61-
}
62-
6348
@Override
6449
public ServingAPIProto.FeatureReferenceV2 getFeatureReference() {
6550
return this.featureReference;

0 commit comments

Comments
 (0)