Skip to content

Commit 766157e

Browse files
committed
Add null value IT
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
1 parent bc183bc commit 766157e

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

serving/src/test/java/feast/serving/it/ServingServiceBigTableIT.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,9 +407,11 @@ public void shouldGetOnlineFeaturesForSingleEntity() {
407407
DataGenerator.createFeatureReference("rides", "trip_cost");
408408
FeatureReferenceV2 notFoundFeatureReference =
409409
DataGenerator.createFeatureReference("rides", "trip_transaction");
410+
FeatureReferenceV2 emptyFeatureReference =
411+
DataGenerator.createFeatureReference("rides", "trip_empty");
410412

411413
ImmutableList<FeatureReferenceV2> featureReferences =
412-
ImmutableList.of(featureReference, notFoundFeatureReference);
414+
ImmutableList.of(featureReference, notFoundFeatureReference, emptyFeatureReference);
413415

414416
// Build GetOnlineFeaturesRequestV2
415417
GetOnlineFeaturesRequestV2 onlineFeatureRequest =
@@ -424,6 +426,8 @@ public void shouldGetOnlineFeaturesForSingleEntity() {
424426
FeatureV2.getFeatureStringRef(featureReference),
425427
DataGenerator.createInt64Value(5),
426428
FeatureV2.getFeatureStringRef(notFoundFeatureReference),
429+
DataGenerator.createEmptyValue(),
430+
FeatureV2.getFeatureStringRef(emptyFeatureReference),
427431
DataGenerator.createEmptyValue());
428432

429433
ImmutableMap<String, GetOnlineFeaturesResponse.FieldStatus> expectedStatusMap =
@@ -433,6 +437,8 @@ public void shouldGetOnlineFeaturesForSingleEntity() {
433437
FeatureV2.getFeatureStringRef(featureReference),
434438
GetOnlineFeaturesResponse.FieldStatus.PRESENT,
435439
FeatureV2.getFeatureStringRef(notFoundFeatureReference),
440+
GetOnlineFeaturesResponse.FieldStatus.NOT_FOUND,
441+
FeatureV2.getFeatureStringRef(emptyFeatureReference),
436442
GetOnlineFeaturesResponse.FieldStatus.NOT_FOUND);
437443

438444
GetOnlineFeaturesResponse.FieldValues expectedFieldValues =

0 commit comments

Comments
 (0)