Skip to content

Revert job controller deployment for docker compose #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woop merged 1 commit into from
Aug 22, 2020
Merged

Revert job controller deployment for docker compose #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion infra/docker-compose/.env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ COMPOSE_PROJECT_NAME=feast
FEAST_VERSION=0.6.2
GCP_SERVICE_ACCOUNT=./gcp-service-accounts/key.json
FEAST_CORE_CONFIG=./core/core.yml
FEAST_JOB_CONTROLLER_CONFIG=./jobcontroller/jobcontroller.yml
FEAST_HISTORICAL_SERVING_CONFIG=./serving/historical-serving.yml
FEAST_HISTORICAL_SERVING_ENABLED=false
FEAST_ONLINE_SERVING_CONFIG=./serving/online-serving.yml
9 changes: 9 additions & 0 deletions infra/docker-compose/core/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
feast:
jobs:
polling_interval_milliseconds: 20000
job_update_timeout_seconds: 240
active_runner: direct
runners:
- name: direct
type: DirectRunner
options:
tempLocation: gs://bucket/tempLocation
stream:
type: kafka
options:
Expand Down
17 changes: 0 additions & 17 deletions infra/docker-compose/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,6 @@ services:
- /opt/feast/feast-core.jar
- --spring.config.location=classpath:/application.yml,file:/etc/feast/application.yml

jobcontroller:
image: gcr.io/kf-feast/feast-jobcontroller:${FEAST_VERSION}
volumes:
- ${FEAST_JOB_CONTROLLER_CONFIG}:/etc/feast/application.yml
- ${GCP_SERVICE_ACCOUNT}:/etc/gcloud/service-accounts/key.json
environment:
GOOGLE_APPLICATION_CREDENTIALS: /etc/gcloud/service-accounts/key.json
depends_on:
- kafka
ports:
- 6570:6570
command:
- java
- -jar
- /opt/feast/feast-job-controller.jar
- --spring.config.location=classpath:/application.yml,file:/etc/feast/application.yml

jupyter:
image: gcr.io/kf-feast/feast-jupyter:${FEAST_VERSION}
volumes:
Expand Down
16 changes: 0 additions & 16 deletions infra/docker-compose/jobcontroller/jobcontroller.yml
View file
Open in desktop

This file was deleted.