fix: detect duplicate feature view/data source names at parse time - #6756
Open
mayuriphad wants to merge 1 commit into
Open
fix: detect duplicate feature view/data source names at parse time#6756mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
mayuriphad
force-pushed
the
fix/flaky-duplicate-featureview-cli-6417
branch
from
August 19, 2026 01:47
2df34a2 to
03e84b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_cli_apply_duplicated_featureview_names(and related tests) intermittently fail in CI with:Root cause: duplicate feature view/data source name detection happens deep inside
store.plan()/store.apply()via_validate_feature_views()/_validate_data_sources()infeature_store.py, afterFeatureStoreand its dependencies (Dask, provider, registry) have already been initialized. On process shutdown, slow atexit handlers (Dask thread pool, PySpark JVM) can block long enough that the test harness's subprocess timeout fires and kills the process withSIGKILLbefore any output is flushed — so the real error message is lost and the test sees only an empty, non-zero exit.The CLI also didn't handle
ConflictingFeatureViewNames/DataSourceRepeatNamesException(bothFeastErrorsubclasses) at all — onlyFeastProviderLoginErrorwas caught — so these errors propagated as unhandled tracebacks.Fix
sdk/python/feast/repo_operations.py: call the existing_validate_feature_views()/_validate_data_sources()validators (imported fromfeature_store.py, no logic duplicated) at the end ofparse_repo(), right after the repo contents are collected — before anyFeatureStore/Dask/PySpark initialization happens. This fails fast, close to where the actual problem (duplicate names in the repo) exists.sdk/python/feast/cli/cli.py: addexcept FeastErrorhandling (after the existingFeastProviderLoginErrorhandler) inplan_commandandapply_total_command, so anyFeastError(including these) is surfaced as a clean message viaclick.ClickExceptionwith a non-zero exit code, rather than an unhandled traceback.Testing
Ran the directly affected tests locally (all pass):
Fixes #6417