Skip to content

fix: Remove inert subjectaccessreviews and reorganize RBAC rules - #6736

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:fix/remove-subjectaccessreviews
Aug 16, 2026
Merged

fix: Remove inert subjectaccessreviews and reorganize RBAC rules#6736
ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:fix/remove-subjectaccessreviews

Conversation

@ntkathole

@ntkathole ntkathole commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Remove the unused subjectaccessreviews from the operator ClusterRole and reorganize the RBAC rules for clusterrolebindings and clusterroles to follow the principle of least privilege.

Changes

  • Remove subjectaccessreviews from both role.yaml and authz.go
  • Separate clusterrolebindings with its own verb set
  • Split clusterroles into general create and named resource management

Test Plan

  • Unit tests passing

@ntkathole
ntkathole requested a review from a team as a code owner August 13, 2026 15:11
@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch from f413d82 to d29cb50 Compare August 13, 2026 15:17
@codecov-commenter

codecov-commenter commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.82%. Comparing base (89240fa) to head (7577f6b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6736   +/-   ##
=======================================
  Coverage   46.82%   46.82%           
=======================================
  Files         415      415           
  Lines       50406    50406           
  Branches     7215     7215           
=======================================
  Hits        23601    23601           
  Misses      25155    25155           
  Partials     1650     1650
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.14% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89240fa...7577f6b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch 2 times, most recently from 9054385 to b93fe1b Compare August 13, 2026 16:16
@ntkathole
fix: Remove inert subjectaccessreviews and reorganize RBAC rules
7577f6b 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole
ntkathole force-pushed the fix/remove-subjectaccessreviews branch from b93fe1b to 7577f6b Compare August 15, 2026 15:42
HaoXuAI
HaoXuAI approved these changes Aug 16, 2026
View reviewed changes

@HaoXuAI HaoXuAI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RBAC split matches the controller's actual CreateOrUpdate and cleanup operations, and removing the inert subjectaccessreviews rules is correct. No blocking findings from my review.

@ntkathole
ntkathole merged commit f771ea4 into feast-dev:master Aug 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoXuAI HaoXuAI HaoXuAI approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntkathole @codecov-commenter @HaoXuAI