fix: Separate CronJob and feature-server ServiceAccounts - #6734
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6734 +/- ##
========================================
Coverage 46.95% 46.96%
========================================
Files 417 418 +1
Lines 51393 51672 +279
Branches 7438 7484 +46
========================================
+ Hits 24132 24267 +135
- Misses 25530 25671 +141
- Partials 1731 1734 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
fix/separate-cronjob-sa
branch
3 times, most recently
from
August 13, 2026 15:55
0fdb9cc to
ac58f3d
Compare
ntkathole
force-pushed
the
fix/separate-cronjob-sa
branch
2 times, most recently
from
August 13, 2026 17:40
8199168 to
b8e32ad
Compare
jyejare
approved these changes
Aug 18, 2026
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ntkathole
force-pushed
the
fix/separate-cronjob-sa
branch
from
August 18, 2026 15:04
b8e32ad to
5dd5be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a dedicated ServiceAccount for CronJob workloads instead of sharing the feature-server ServiceAccount, ensuring proper privilege separation between components.
Changes
createCronJobServiceAccount()with dedicated SA for CronJobsTest Plan