Skip to content

Clean up Docker Compose and add test #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 13 commits into from
May 5, 2020
Merged

Clean up Docker Compose and add test #668

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fd46ae1
Modularize Docker Compose files
woop May 1, 2020
cb40963
Add docker compose test
woop May 1, 2020
16b5d1d
Add GitHub Actions Docker Compose workflow
woop May 1, 2020
76132a7
Fix typos and environment file
woop May 1, 2020
ff5c895
Get docker container address from docker
woop May 1, 2020
88c2a06
Externalize startup script for docker container
woop May 1, 2020
9512211
Remove unnecessary Feast SDK installation
woop May 1, 2020
d39dc26
Clean up Basic notebook parameters
woop May 1, 2020
e3d1631
Small changes (whitespace and comments)
woop May 2, 2020
2f5f923
Add wait-for-it bash script
woop May 5, 2020
d385868
Shut down docker compose when done
woop May 5, 2020
7b8e288
Allow docker-compose files to run independently
woop May 5, 2020
3ce193b
Allow Jupyter Notebook clone step to always succeed
woop May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get docker container address from docker
  • Loading branch information
@woop
woop committed May 1, 2020
commit ff5c895abfb807153b27b20fdf6765d1a7f09670
13 changes: 12 additions & 1 deletion infra/scripts/test-docker-compose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,18 @@ Running Docker Compose tests with pytest at 'tests/e2e'
"
PROJECT_ROOT_DIR=$(git rev-parse --show-toplevel)
cd ${PROJECT_ROOT_DIR}/infra/docker-compose/

# Create Docker Compose configuration file
cp .env.sample .env

# Start all Docker Compose containers
docker-compose -f docker-compose.yml -f docker-compose.online.yml up -d
timeout 3m bash -c 'until [ $(curl -s localhost:8888/tree | grep notebook | wc -l) -gt 0 ]; do echo waiting for Jupyter to start...; sleep 10; done'

# Get Docker Container IP address
JUPYTER_DOCKER_CONTAINER_IP_ADDRESS=$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' feast_jupyter_1)

# Wait for Jupyter Notebook Container to be online
timeout 5m bash -c 'until [ $(curl -s ${JUPYTER_DOCKER_CONTAINER_IP_ADDRESS}:8888/tree | grep notebook | wc -l) -gt 0 ]; do echo waiting for Jupyter to start...; curl -s ${JUPYTER_DOCKER_CONTAINER_IP_ADDRESS}:8888/tree; sleep 10; done'

# Run e2e tests for Redis
docker exec -it feast_jupyter_1 bash -c 'cd feast/tests/e2e/ && pytest -s basic-ingest-redis-serving.py --core_url core:6565 --serving_url=online-serving:6566'