Skip to content

chore: Remove upper version bound for uvicorn - #6662

Merged
ntkathole merged 6 commits into
feast-dev:masterfrom
nanohanno:hk/loosen-uvicorn-upper-bound
Jul 31, 2026
Merged

chore: Remove upper version bound for uvicorn#6662
ntkathole merged 6 commits into
feast-dev:masterfrom
nanohanno:hk/loosen-uvicorn-upper-bound

Conversation

@nanohanno

@nanohanno nanohanno commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removes the upper bound for uvicorn which is very restrictive now that uvicorn is at v0.52.0.
It picks up where PR #5802 left.

I had to make two changes in the Makefile that were assisted by AI to get the dependency locking recipe working.

Which issue(s) this PR fixes:

Fixes #5677

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

@nanohanno
nanohanno requested a review from a team as a code owner July 29, 2026 15:49
@nanohanno
nanohanno force-pushed the hk/loosen-uvicorn-upper-bound branch 2 times, most recently from 34bba5d to c72e1a4 Compare July 29, 2026 15:54
@nanohanno
nanohanno marked this pull request as draft July 29, 2026 15:55
@codecov-commenter

codecov-commenter commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.46%. Comparing base (c8628eb) to head (eb46846).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6662   +/-   ##
=======================================
  Coverage   46.45%   46.46%           
=======================================
  Files         414      414           
  Lines       50138    50138           
  Branches     7173     7173           
=======================================
+ Hits        23294    23295    +1     
  Misses      25204    25204           
+ Partials     1640     1639    -1
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 47.76% <ø> (+<0.01%) ⬆️
see 1 file with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7667215...eb46846. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nanohanno
nanohanno marked this pull request as ready for review July 30, 2026 09:56
@nanohanno

nanohanno commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

I had to do some changes on ruff config and markdown files due to the recent ruff version update that changes default rules and enables python formatting in markdown blocks: https://astral.sh/blog/ruff-v0.16.0
I used the suggested configuration to keep the old default linting rules in place. I suggest to remove it in a separate PR, fix the issues and proceed with the updated default rules.

@nanohanno

nanohanno commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Updated pixi lock, hope that fixes the failing integration tests.

ntkathole
ntkathole reviewed Jul 30, 2026
View reviewed changes
Comment thread sdk/python/feast/templates/pytorch_nlp/README.md Outdated
@ntkathole

ntkathole commented Jul 30, 2026

Copy link
Copy Markdown
Member

@nanohanno Merging another PR caused conflicts on this, can you please resolve the conflicts ?

@nanohanno
nanohanno force-pushed the hk/loosen-uvicorn-upper-bound branch from 5a47b1e to 0c73447 Compare July 30, 2026 18:07
@nanohanno

nanohanno commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@nanohanno Merging another PR caused conflicts on this, can you please resolve the conflicts ?

Sure, I rebased and executed the pixi locking again just to be safe. Could the unit-test-go failure be solved by re-running the job or is that somehow touched by the changes?

nanohanno added 6 commits July 31, 2026 09:48
@nanohanno @ntkathole
chore: Remove upper version bound for uvicorn
edf46f3 
Signed-off-by: nanohanno <kuepers@posteo.de>
@nanohanno @ntkathole
chore: Use old ruff default rule set
183e51b 
Signed-off-by: nanohanno <kuepers@posteo.de>
@nanohanno @ntkathole
chore: Ruff format on md files
7699bd0 
Signed-off-by: nanohanno <kuepers@posteo.de>
@nanohanno @ntkathole
chore: Update pixi lock
399dd2a 
Signed-off-by: nanohanno <kuepers@posteo.de>
@nanohanno @ntkathole
chore: Bump pixi version in ci to v0.75.0
5d9319f 
Signed-off-by: nanohanno <kuepers@posteo.de>
@nanohanno @ntkathole
fix: Suppress code block formatting in nlp tutorial
eb46846 
Signed-off-by: nanohanno <kuepers@posteo.de>
@ntkathole
ntkathole force-pushed the hk/loosen-uvicorn-upper-bound branch from 0c73447 to eb46846 Compare July 31, 2026 04:18
@ntkathole
ntkathole merged commit 4f6b821 into feast-dev:master Jul 31, 2026
21 of 28 checks passed
jyejare pushed a commit to opendatahub-io/feast that referenced this pull request Aug 5, 2026
@nanohanno @jyejare
chore: Remove upper version bound for uvicorn (feast-dev#6662)
b9644c1 
* chore: Remove upper version bound for uvicorn

Signed-off-by: nanohanno <kuepers@posteo.de>

* chore: Use old ruff default rule set

Signed-off-by: nanohanno <kuepers@posteo.de>

* chore: Ruff format on md files

Signed-off-by: nanohanno <kuepers@posteo.de>

* chore: Update pixi lock

Signed-off-by: nanohanno <kuepers@posteo.de>

* chore: Bump pixi version in ci to v0.75.0

Signed-off-by: nanohanno <kuepers@posteo.de>

* fix: Suppress code block formatting in nlp tutorial

Signed-off-by: nanohanno <kuepers@posteo.de>

---------

Signed-off-by: nanohanno <kuepers@posteo.de>
@larrysingleton007 larrysingleton007 mentioned this pull request Aug 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes
@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsolvable dependency conflict between uvicorn and uvicorn-worker

4 participants

@nanohanno @codecov-commenter @ntkathole @franciscojavierarceo