fix: Handle parameterized and complex Trino types in type map - #6496
Merged
ntkathole merged 1 commit intoAug 18, 2026
Merged
Conversation
ntkathole
force-pushed
the
fix/trino-type-map-parameterized-types
branch
from
August 18, 2026 04:14
8ef4d61 to
8605a05
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6496 +/- ##
==========================================
+ Coverage 46.92% 47.12% +0.20%
==========================================
Files 416 416
Lines 50537 50614 +77
Branches 7252 7267 +15
==========================================
+ Hits 23714 23853 +139
+ Misses 25149 25072 -77
- Partials 1674 1689 +15
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
force-pushed
the
fix/trino-type-map-parameterized-types
branch
from
August 18, 2026 04:49
8605a05 to
1c7441f
Compare
Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
ntkathole
force-pushed
the
fix/trino-type-map-parameterized-types
branch
from
August 18, 2026 05:33
1c7441f to
cff0ade
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes
trino_type_map.pyto properly handle parameterized Trino types (e.g.,varchar(10),decimal(10,2)) and complex types (array(...),row(...),map(...)). Previously,\w+regex inarray(...)parsing, missing type map entries forvarbinary/json/int/char(...), and unhandledrow(...)/map(...)causedAttributeError,KeyError, orUnboundLocalErrorat runtime during schema introspection.Which issue(s) this PR fixes:
Fixes #6489
Checks
git commit -s)Testing Strategy