Skip to content

fix: Integration test failures #6040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 3 commits into from
Mar 1, 2026
Merged

fix: Integration test failures #6040

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e21dc0
fix: integration test failures
tokoko Mar 1, 2026
c58bc4e
fix: remote online store
tokoko Mar 1, 2026
c41d617
fix: ignore ray
tokoko Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remote online store 
Signed-off-by: tokoko <togurgenidze@gmail.com>
  • Loading branch information
@tokoko
tokoko committed Mar 1, 2026
commit c58bc4e798675b8858416fd2d5c205a9bd2ce513
30 changes: 14 additions & 16 deletions sdk/python/tests/unit/infra/online_store/test_remote_online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ def test_retrieve_online_documents_success(
call_args = mock_get_remote_online_documents.call_args
assert call_args[1]["config"] == config

# Parse the request body to verify it's correct
req_body = json.loads(call_args[1]["req_body"])
# Verify the request body dict is correct
req_body = call_args[1]["req_body"]
assert req_body["features"] == ["test_feature_view:feature1"]
assert req_body["query"] == [0.1, 0.2, 0.3]
assert req_body["top_k"] == 2
Expand Down Expand Up @@ -189,8 +189,8 @@ def test_retrieve_online_documents_v2_success(
call_args = mock_get_remote_online_documents.call_args
assert call_args[1]["config"] == config

# Parse the request body to verify it's correct
req_body = json.loads(call_args[1]["req_body"])
# Verify the request body dict is correct
req_body = call_args[1]["req_body"]
assert req_body["features"] == ["test_feature_view:feature1"]
assert req_body["query"] == [0.1, 0.2, 0.3]
assert req_body["top_k"] == 2
Expand Down Expand Up @@ -302,14 +302,13 @@ def test_construct_online_documents_api_json_request(
distance_metric="cosine",
)

parsed_result = json.loads(result)
assert parsed_result["features"] == [
assert result["features"] == [
"test_feature_view:feature1",
"test_feature_view:feature2",
]
assert parsed_result["query"] == [0.1, 0.2, 0.3]
assert parsed_result["top_k"] == 5
assert parsed_result["distance_metric"] == "cosine"
assert result["query"] == [0.1, 0.2, 0.3]
assert result["top_k"] == 5
assert result["distance_metric"] == "cosine"

def test_construct_online_documents_v2_api_json_request(
self, remote_store, feature_view
Expand All @@ -325,13 +324,12 @@ def test_construct_online_documents_v2_api_json_request(
api_version=2,
)

parsed_result = json.loads(result)
assert parsed_result["features"] == ["test_feature_view:feature1"]
assert parsed_result["query"] == [0.1, 0.2]
assert parsed_result["top_k"] == 3
assert parsed_result["distance_metric"] == "L2"
assert parsed_result["query_string"] == "test query"
assert parsed_result["api_version"] == 2
assert result["features"] == ["test_feature_view:feature1"]
assert result["query"] == [0.1, 0.2]
assert result["top_k"] == 3
assert result["distance_metric"] == "L2"
assert result["query_string"] == "test query"
assert result["api_version"] == 2

def test_extract_requested_feature_value(self, remote_store):
"""Test _extract_requested_feature_value helper method."""
Expand Down
7 changes: 3 additions & 4 deletions sdk/python/tests/unit/infra/test_key_encoding_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,9 @@ def test_performance_bounds_single_entity():
deserialize_entity_key(serialized, entity_key_serialization_version=3)
deserialize_time = time.perf_counter() - start

# Conservative performance bounds (should be much faster with optimizations)
# 1000 operations should complete in < 20ms each for serialization and deserialization
assert serialize_time < 0.02, f"Serialization too slow: {serialize_time:.4f}s"
assert deserialize_time < 0.02, f"Deserialization too slow: {deserialize_time:.4f}s"
# Performance bounds with generous thresholds to avoid flaky failures on CI runners
assert serialize_time < 0.1, f"Serialization too slow: {serialize_time:.4f}s"
assert deserialize_time < 0.1, f"Deserialization too slow: {deserialize_time:.4f}s"


def test_non_ascii_prefix_compatibility():
Expand Down
Loading