refactor: Centralize feature view object lookup #5898
+76
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ed05c to
20d5920
Compare
20d5920 to
256012d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase by centralizing the repeated logic for resolving feature view-like names (FeatureView, OnDemandFeatureView, StreamFeatureView) into shared utility functions, reducing code duplication and improving maintainability.
Changes:
- Added two new helper functions in
feature_view_utils.pyfor centralized feature view lookup - Updated
feature_server.pyto use the new centralized lookup function - Updated
feature_logging.pyto use the new centralized lookup function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/python/feast/feature_view_utils.py | Added get_feast_object_from_feature_store and get_feast_object_from_registry helper functions |
| sdk/python/feast/feature_server.py | Replaced duplicated try/except lookup logic with call to get_feast_object_from_feature_store |
| sdk/python/feast/feature_logging.py | Replaced duplicated try/except lookup logic with call to get_feast_object_from_registry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
256012d to
5f3a571
Compare
Signed-off-by: antznette1 <Ochiezeanthonette@gmail.com>
5f3a571 to
dd5c9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Summary
This PR centralizes the repeated logic used to resolve a “feature view-like” name into the correct Feast object type:
Previously, this lookup pattern was duplicated across multiple Python SDK/server components.
What changed
Motivation
Notes / Testing
Local sanity check: python -m compileall on the modified files.