fix: Image utils optional dependency errors and unblock unit tests on minimal env #5808

Shizoqua · 2026-01-02T23:17:47Z

Summary

This PR fixes behavior in feast.image_utils when optional image dependencies are not installed, and adds unit tests to cover the expected failure mode.

While validating the fix locally, I also addressed a few test-harness issues that prevented running unit tests in a minimal environment (without integration/auth optional deps).

Changes

Ensure validate_image_format and get_image_metadata call _check_image_dependencies() so they raise a clear ImportError when feast[image] deps are missing (instead of failing with a NameError due to missing PIL.Image).
Add unit tests for missing optional image dependencies:
- sdk/python/tests/unit/test_image_utils_optional_deps.py
Unblock unit test execution in minimal environments:
- Update pytest.ini for pytest 8 compatibility (remove invalid warning filter) and remove env= config that requires extra plugins.
- Make tests/conftest.py safe to import without optional integration/auth dependencies (guard imports).
- Fix Windows multiprocessing start method selection (sys.platform is win32, not windows).

Why

Prevent confusing runtime failures when optional feast[image] dependencies are not installed.
Improve contributor experience by allowing unit tests to run without requiring integration-only packages.

Test Plan

python -m pytest -q tests/unit/test_image_utils_optional_deps.py

Copilot

Pull request overview

This PR fixes error handling in feast.image_utils when optional image dependencies are missing and enables unit tests to run in minimal environments without integration dependencies.

Adds _check_image_dependencies() calls to validate_image_format and get_image_metadata to raise clear ImportError when image dependencies are missing
Adds unit tests to verify optional dependency handling
Updates test infrastructure to support running unit tests without optional integration/auth dependencies

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
sdk/python/feast/image_utils.py	Added dependency checks to image validation and metadata extraction functions
sdk/python/tests/unit/test_image_utils_optional_deps.py	New unit tests verifying ImportError behavior when image dependencies are unavailable
sdk/python/tests/conftest.py	Wrapped integration and auth test imports in try-except blocks to allow conftest loading without optional dependencies; fixed Windows platform detection
sdk/python/pytest.ini	Removed deprecated pytest configuration for pytest 8 compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sdk/python/tests/conftest.py

sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py

sdk/python/pytest.ini

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com> Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

…s.py Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Shizoqua · 2026-01-12T21:01:30Z

Good day @franciscojavierarceo
I would appreciate it if my PR is looked at and reviewed.

Shizoqua · 2026-01-16T01:42:04Z

Good day @franciscojavierarceo
I would appreciate it if my PR is reviewed.

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Shizoqua · 2026-01-19T20:25:47Z

Hello,
Good day @franciscojavierarceo
Just a quick reminder of my PR getting reviewed.

devin-ai-integration

Devin Review found 1 potential issue.

View issue and 6 additional flags in Devin Review.

devin-ai-integration · 2026-01-26T14:56:12Z

sdk/python/tests/conftest.py

+    if not _integration_test_deps_available:
+        pytest.skip("Integration test dependencies are not available")


🔴 pytest.skip() called during test collection causes collection error instead of graceful skip

Calling pytest.skip() inside pytest_generate_tests() at line 292 is incorrect and will cause a collection error rather than gracefully skipping the test.

Click to expand

Problem

pytest.skip() raises a Skipped exception that is designed to be caught by pytest's test runner during test execution, not during test collection. When called in pytest_generate_tests(), it will cause pytest to report a collection error.

Code path

When _integration_test_deps_available is False (dependencies not installed), the code reaches:

if not _integration_test_deps_available: pytest.skip("Integration test dependencies are not available")

This will raise pytest.skip.Exception which is not handled during collection, causing the test suite to error out instead of skipping the tests gracefully.

Proper fix

The correct approach would be to either:

Return early and not parametrize the test (which may cause fixture errors)

Use metafunc.parametrize() with an empty list and mark with pytest.mark.skip

Use pytest.skip(allow_module_level=True) at module level before pytest_generate_tests is called

Impact

When running tests without integration dependencies installed, the test collection will fail with an error instead of gracefully skipping the affected tests.

Was this helpful? React with 👍 or 👎 to provide feedback.

Shizoqua requested a review from a team as a code owner January 2, 2026 23:17

Shizoqua force-pushed the bugfix/contrib-quickfix branch from 017a91a to fc9bb71 Compare January 2, 2026 23:20

franciscojavierarceo requested a review from Copilot January 3, 2026 05:10

Copilot AI reviewed Jan 3, 2026

View reviewed changes

sdk/python/tests/conftest.py Show resolved Hide resolved

sdk/python/tests/conftest.py Outdated Show resolved Hide resolved

Shizoqua force-pushed the bugfix/contrib-quickfix branch 2 times, most recently from 35db3ae to d8fd430 Compare January 9, 2026 02:03

franciscojavierarceo reviewed Jan 9, 2026

View reviewed changes

sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py Show resolved Hide resolved

franciscojavierarceo reviewed Jan 9, 2026

View reviewed changes

sdk/python/pytest.ini Show resolved Hide resolved

Shizoqua and others added 5 commits January 10, 2026 05:06

Fix image utils optional deps errors

e96f7d6

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com> Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

tests: clarify platform detection and marker handling in conftest

13356c0

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com> Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

fix: avoid creating empty Milvus indexes

1f16439

Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Delete sdk/python/feast/infra/online_stores/milvus_online_store/milvu…

62fde30

…s.py Signed-off-by: Lanre Shittu <136805224+Shizoqua@users.noreply.github.com> Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Restore Milvus online store file

2b2a4f2

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Shizoqua force-pushed the bugfix/contrib-quickfix branch from bdd4b82 to 2b2a4f2 Compare January 10, 2026 04:06

Shizoqua requested a review from franciscojavierarceo January 10, 2026 04:07

test: fix ruff imports and stabilize CLI runner env

e3efbf3

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Shizoqua and others added 2 commits January 18, 2026 21:32

test: ruff format optional deps test

167a08b

Signed-off-by: Shizoqua <hr.lanreshittu@yahoo.com>

Merge branch 'master' into bugfix/contrib-quickfix

8aba462

devin-ai-integration bot reviewed Jan 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Image utils optional dependency errors and unblock unit tests on minimal env #5808

fix: Image utils optional dependency errors and unblock unit tests on minimal env #5808

Shizoqua commented Jan 2, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shizoqua commented Jan 12, 2026

Uh oh!

Shizoqua commented Jan 16, 2026

Uh oh!

Shizoqua commented Jan 19, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if not _integration_test_deps_available:
		pytest.skip("Integration test dependencies are not available")

fix: Image utils optional dependency errors and unblock unit tests on minimal env #5808

Are you sure you want to change the base?

fix: Image utils optional dependency errors and unblock unit tests on minimal env #5808

Conversation

Shizoqua commented Jan 2, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Why

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shizoqua commented Jan 12, 2026

Uh oh!

Shizoqua commented Jan 16, 2026

Uh oh!

Shizoqua commented Jan 19, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Jan 26, 2026

Choose a reason for hiding this comment

Problem

Code path

Proper fix

Impact

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Shizoqua commented Jan 2, 2026 •

edited by devin-ai-integration bot

Loading