Skip to content

fix: Make pytest config compatible with newer pytest #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Jul 10, 2026
Merged

fix: Make pytest config compatible with newer pytest #5779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@
"filename": "infra/feast-operator/api/v1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 936
"line_number": 937
}
],
"infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
Expand Down Expand Up @@ -989,7 +989,7 @@
"filename": "infra/feast-operator/api/v1alpha1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 650
"line_number": 651
}
],
"infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go": [
Expand Down Expand Up @@ -1555,5 +1555,5 @@
}
]
},
"generated_at": "2026-06-26T06:19:05Z"
"generated_at": "2026-07-10T13:52:47Z"
}
3 changes: 2 additions & 1 deletion infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ type OnlineStoreFilePersistence struct {
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
type OnlineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb;aerospike
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb;aerospike;scylladb
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -653,6 +653,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
"hybrid",
"mongodb",
"aerospike",
"scylladb",
}

// LocalRegistryConfig configures the registry service
Expand Down
3 changes: 2 additions & 1 deletion infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ type OnlineStoreFilePersistence struct {
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
type OnlineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb;aerospike
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb;aerospike;scylladb
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -400,6 +400,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
"hybrid",
"mongodb",
"aerospike",
"scylladb",
}

// LocalRegistryConfig configures the registry service
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,6 +2400,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -8706,6 +8707,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -14230,6 +14232,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -18736,6 +18739,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2408,6 +2408,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -8714,6 +8715,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -14238,6 +14240,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down Expand Up @@ -18744,6 +18747,7 @@ spec:
- hybrid
- mongodb
- aerospike
- scylladb
type: string
required:
- secretRef
Expand Down
7 changes: 4 additions & 3 deletions pixi.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 18 additions & 4 deletions sdk/python/feast/infra/online_stores/sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import os
import sqlite3
import sys
import time
from datetime import date, datetime, timezone
from pathlib import Path
from typing import (
Expand Down Expand Up @@ -353,10 +354,23 @@ def teardown(
tables: Sequence[FeatureView],
entities: Sequence[Entity],
):
try:
os.unlink(self._get_db_path(config))
except FileNotFoundError:
pass
if self._conn is not None:
try:
self._conn.close()
finally:
self._conn = None

db_path = self._get_db_path(config)
for attempt in range(10):
try:
os.unlink(db_path)
return
except FileNotFoundError:
return
except PermissionError:
if attempt == 9:
raise
time.sleep(0.25)

def retrieve_online_documents(
self,
Expand Down
6 changes: 6 additions & 0 deletions sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@ def get_registry_store_class_from_type(registry_store_type: str):

def get_registry_store_class_from_scheme(registry_path: str):
uri = urlparse(registry_path)
if uri.scheme == "" or (
len(uri.scheme) == 1 and registry_path[1:3] in (":\\", ":/")
):
registry_store_type = REGISTRY_STORE_CLASS_FOR_SCHEME["file"]
return get_registry_store_class_from_type(registry_store_type)

if uri.scheme not in REGISTRY_STORE_CLASS_FOR_SCHEME:
raise Exception(
f"Registry path {registry_path} has unsupported scheme {uri.scheme}. "
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ asyncio_mode = auto
env =
IS_TEST=True
filterwarnings =
error::_pytest.warning_types.PytestConfigWarning
error::_pytest.warning_types.PytestUnhandledCoroutineWarning
error::pytest.PytestConfigWarning
error:.*was never awaited.*:RuntimeWarning
ignore::DeprecationWarning:pyspark.sql.pandas.*:
ignore::DeprecationWarning:pyspark.sql.connect.*:
ignore::DeprecationWarning:httpx.*:
Expand Down
Loading
Loading