fix: Made URL to registry relative, fixes #2731 - #2753
Conversation
Signed-off-by: Huib Keemink <huib.keemink@jedlix.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, creativedutchmen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2753 +/- ##
==========================================
- Coverage 80.44% 80.40% -0.04%
==========================================
Files 171 171
Lines 14571 14571
==========================================
- Hits 11721 11716 -5
- Misses 2850 2855 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Instead of having the URL to the registry be absolute (default to 0.0.0.0:8888), use a relative path. This means there's no SSL issues when putting the UI behind a SSL proxy, nor will it try to load it from localhost. This change allows the UI to be deployed to a central location.
Fixes #2731