Skip to content

chore: Fix minor documentation typo - #2752

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
chhabrakadabra:datasource-docs-fix
Jun 1, 2022
Merged

chore: Fix minor documentation typo#2752
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
chhabrakadabra:datasource-docs-fix

Conversation

@chhabrakadabra

@chhabrakadabra chhabrakadabra commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

The python API docs for data_source have a confusing typo.

01-13-9487k-k4ab1

Based on the docs, it's unclear what the recommended path forward is. It looks like the recommendation is to use timestamp_field.

image

Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com

Which issue(s) this PR fixes:

Fixes #

@chhabrakadabra
Fix minor documentation typo
bf7787c 
Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
@codecov-commenter

codecov-commenter commented Jun 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2752 (bf7787c) into master (3d2b431) will decrease coverage by 21.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2752       +/-   ##
===========================================
- Coverage   80.27%   58.73%   -21.54%     
===========================================
  Files         169      169               
  Lines       14368    14366        -2     
===========================================
- Hits        11534     8438     -3096     
- Misses       2834     5928     +3094
Flag Coverage Δ
integrationtests ?
unittests 58.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 83.57% <ø> (-0.29%) ⬇️
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (-73.03%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2b431...bf7787c. Read the comment docs.

felixwang9817
felixwang9817 approved these changes Jun 1, 2022
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chhabrakadabra, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 5a7fcef into feast-dev:master Jun 1, 2022
adchia pushed a commit that referenced this pull request Jun 13, 2022
@chhabrakadabra @adchia
chore: Fix minor documentation typo (#2752)
df4c688 
Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chhabrakadabra @codecov-commenter @feast-ci-bot @felixwang9817