chore: Respect environment variables when calling check_call - #2741
Merged
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
pyalex
approved these changes
May 27, 2022
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
==========================================
- Coverage 80.16% 80.06% -0.10%
==========================================
Files 167 169 +2
Lines 14324 15001 +677
==========================================
+ Hits 11483 12011 +528
- Misses 2841 2990 +149
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
adchia
pushed a commit
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Achal Shah <achals@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
If we set something like PYTHONUSERBASE for gitpod builds, then the site-packages for python are located in a non-standard location and modules cannot be located. This fixes that by inheriting the python process' environment.
Which issue(s) this PR fixes:
Fixes #