chore: Remove misleading connection option from redis docstring - #2725
Merged
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2725 +/- ##
==========================================
- Coverage 80.26% 80.22% -0.05%
==========================================
Files 167 167
Lines 14154 14154
==========================================
- Hits 11361 11355 -6
- Misses 2793 2799 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
adchia
pushed a commit
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Achal Shah <achals@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
decode_responsesis only useful if we want to read values as strings instead of bytes. But in the existing implementation, we store keys and values in redis as bytes.Which issue(s) this PR fixes:
Fixes #