Skip to content

docs: Add reference to workshop - #2723

Merged
adchia merged 3 commits into
masterfrom
addWorkshop
May 20, 2022
Merged

docs: Add reference to workshop#2723
adchia merged 3 commits into
masterfrom
addWorkshop

Conversation

@adchia

@adchia adchia commented May 20, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This adds the workshop link to getting-started

Which issue(s) this PR fixes:

Fixes #

@adchia
fix: Add workshop link to documentation
513313f 
Signed-off-by: Danny Chiao <danny@tecton.ai>
achals
achals approved these changes May 20, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented May 20, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
rename link
f028279 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label May 20, 2022
@feast-ci-bot

feast-ci-bot commented May 20, 2022

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@adchia
rename link
c659876 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
adchia enabled auto-merge (squash) May 20, 2022 17:29
@codecov-commenter

codecov-commenter commented May 20, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2723 (c659876) into master (c5539fd) will decrease coverage by 21.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2723       +/-   ##
===========================================
- Coverage   80.19%   59.12%   -21.07%     
===========================================
  Files         167      167               
  Lines       14021    15559     +1538     
===========================================
- Hits        11244     9200     -2044     
- Misses       2777     6359     +3582
Flag Coverage Δ
integrationtests ?
unittests 59.12% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.05% <0.00%> (-79.95%) ⬇️
.../integration/online_store/test_universal_online.py 17.70% <0.00%> (-72.79%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
.../integration/offline_store/test_feature_logging.py 30.15% <0.00%> (-69.85%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 32.92% <0.00%> (-67.08%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5539fd...c659876. Read the comment docs.

@adchia
adchia merged commit 568a0ff into master May 20, 2022
@achals
achals deleted the addWorkshop branch May 20, 2022 18:00
adchia added a commit that referenced this pull request May 20, 2022
@adchia
docs: Add reference to workshop (#2723)
8b34123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adchia @feast-ci-bot @codecov-commenter @achals