Skip to content

new protobuf for online features response - #2662

Merged
pyalex merged 2 commits into
feast-dev:v0.9-branchfrom
keshav2211:v0.9-branch
May 17, 2022
Merged

new protobuf for online features response#2662
pyalex merged 2 commits into
feast-dev:v0.9-branchfrom
keshav2211:v0.9-branch

Conversation

@keshav2211

Copy link
Copy Markdown

Signed-off-by: KeshavSharma keshav.sharma@gojek.com

What this PR does / why we need it:

  • Add new protobuf message and service for getOnlineFeatureResponseV2
  • Update go sdk to use new protobuf message for online features response

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: KeshavSharma <keshav.sharma@gojek.com>
@khorshuheng

Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keshav2211, khorshuheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: KeshavSharma <keshav.sharma@gojek.com>
@pyalex
pyalex merged commit e939430 into feast-dev:v0.9-branch May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants