Skip to content

Update feature_view.py - #1794

Closed
yrbahn wants to merge 2 commits into
feast-dev:masterfrom
yrbahn:master
Closed

Update feature_view.py#1794
yrbahn wants to merge 2 commits into
feast-dev:masterfrom
yrbahn:master

Conversation

@yrbahn

@yrbahn yrbahn commented Aug 20, 2021

Copy link
Copy Markdown

check if the value of batch_source_proto is None.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


check if the value of batch_source_proto is None.
@yrbahn
yrbahn requested review from achals and tsotnet as code owners August 20, 2021 16:29
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@yrbahn: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yrbahn
To complete the pull request process, please assign achals after the PR has been reviewed.
You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

Hi @yrbahn. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yrbahn yrbahn closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants