fix(comments): author-only delete and validate target ids#4
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7953dd2 to
db457fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes two Codex findings on the comments routes.
P1 — delete authorization was UI-only. Any org member who knew a comment id could
DELETE /api/comments/[id]. The kebab menu already hides Delete for non-authors; the server now enforces the same rule (403 ifauthorUserId !== session.userId). Resolve/reopen remains org-wide, matching the UI which surfaces it to everyone.P2 — comment creation didn't validate targets.
POST /api/commentswrotetargetIdblindly because the column is polymorphic and carries no FK. Now:MESSAGEtargets must resolve to a Message in the caller's org (via auto-scoped findUnique).DOCUMENT_REGIONtargets must resolve to a Document in the caller's org, and the location'skindmust match the document's format (pdffor PDFs,htmlfor DOCX/HTML/MD) so the viewer never gets a region it can't render.Verified with
yarn test(52 unit) andyarn lint.