test: fix path traversal tests after supertest v7.x upgrade#138
Open
Tony133 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
test/send.1.test.jsto unblock upgrading tosupertest@7.0.0. Supertest v7 strictly adheres to the WHATWG URL standard. It now automatically normalizes URL paths on the client-side before sending the request.As a result, a path like
/pets/%2e%2e/%2e%2e/send.jsgets resolved to/send.jsbefore hitting the network. The server never receives the traversal payload, resulting in a404 Not Foundinstead of the expected403 Forbidden.Note: