fix memory-module crash with dll align with 512 - #21
Closed
progmboy wants to merge 3 commits into
Closed
Conversation
Owner
|
How can I create such a DLL for testing? Do you use |
Author
|
yes. i use /align:512 in order to get the smallest binary |
Author
|
Hmm. There still some problems. if some sections in one page and any section have different Characteristics.. if the last section's Characteristics have no executable attribute.. the memory-module will be crash cause by DEP |
Author
|
And here is a test dll link with 512 |
…te would be covered by the next section's.
fancycode
added a commit
that referenced
this pull request
Feb 28, 2015
Owner
|
Thanks for the initial suggestions. This is implemented now, however I had to change a couple of things to support more cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if dll align with 512 the section->VirtualAddress will lower than a page size. and virtualalloc will return the page base but not the next page..
eg. section->VirtualAddress = 0x200, codebase = 0x1000000
dest = (unsigned char *)VirtualAlloc(codeBase + section->VirtualAddress,
section->SizeOfRawData,
MEM_COMMIT,
PAGE_READWRITE);
the dest will be 0x1000000..
so the memory-module will crash