Fix webserver thread safety #350
Merged
+107
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move opening brace to end of line in policy_callback - Replace using-directive with using-declaration for chrono_literals - Use static_cast instead of C-style cast - Use rand_r instead of rand for thread safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #330
Description
This PR introduces mutex protection for webserver member variables to prevent data races (fixes #329).
Changes
std::shared_mutexforregistered_resources,bans, andallowancesshared_lockfor read operations,unique_lockfor write operationsconst(single_resource,tcp_nodelay, error handler pointers)policy_callbackcondition for better readabilityCredit
Original work by @FlorianChevassu - rebased onto master to resolve conflicts and pick up CI fixes.
Co-authored-by: Florian CHEVASSU fchevassu@antidot.net