Skip to content

Use synchronous control flow when making synchronous requests #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kategengler merged 1 commit into from
Jan 5, 2017
Merged

Use synchronous control flow when making synchronous requests #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 41 additions & 29 deletions lib/templates/test-body-footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script>
// Make synchronous requests in phantom to avoid killing the runner before the coverage completes.
var REQUEST_ASYNC = !/PhantomJS/.test(window.navigator.userAgent);

function sendCoverage(callback) {
Object.keys(require.entries).forEach(function(file) {
// Only load non-test files from the project
Expand All @@ -21,38 +22,18 @@
request.open('POST', '/write-coverage', REQUEST_ASYNC);
request.setRequestHeader('Content-Type', 'application/json; charset=utf-8');
request.send(data);
request.responseType = 'json';

request.onload = function() {
var data = this.response;

// PhantomJS doesn't honor `responseType = 'json'`
if (typeof data === 'string') {
data = JSON.parse(data);
}

if (!data || !data.total) {
return;
if (REQUEST_ASYNC) {
request.responseType = 'json';
request.onload = function() {
handleCoverageResponse(this, callback);
}

var results = ['Lines', 'Branches', 'Functions', 'Statements']
.filter(function (name) {
return data.total[name.toLowerCase()]
})
.map(function (name) {
return name + ' ' + data.total[name.toLowerCase()].pct + '%'
});

var resultsText = document.createTextNode(results.join(' | '));
var element = document.createElement('div');
element.style = 'background-color: white; color: black; border: 2px solid black; padding: 1em;position: fixed; left: 15px; bottom: 15px';
element.appendChild(resultsText);
document.body.appendChild(element);

if (callback) {
callback();
} else {
// The request is already done at this point, since it is synchronous
if (request.status === 200) {
handleCoverageResponse(request, callback);
}
};
}
}

if (typeof Testem !== "undefined" && Testem.afterTests) {
Expand All @@ -64,4 +45,35 @@
sendCoverage();
});
}

function handleCoverageResponse(xhr, callback) {
var data = xhr.response;

// PhantomJS doesn't honor `responseType = 'json'`
if (typeof data === 'string') {
data = JSON.parse(data);
}

if (!data || !data.total) {
return;
}

var results = ['Lines', 'Branches', 'Functions', 'Statements']
.filter(function (name) {
return data.total[name.toLowerCase()]
})
.map(function (name) {
return name + ' ' + data.total[name.toLowerCase()].pct + '%'
});

var resultsText = document.createTextNode(results.join(' | '));
var element = document.createElement('div');
element.style = 'background-color: white; color: black; border: 2px solid black; padding: 1em;position: fixed; left: 15px; bottom: 15px';
element.appendChild(resultsText);
document.body.appendChild(element);

if (callback) {
callback();
}
}
</script>