Skip to content

Fix phantomjs request aborted edge case #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kategengler merged 1 commit into from
Nov 30, 2016
Merged

Fix phantomjs request aborted edge case #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/templates/test-body-footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script>
// Make synchronous requests in phantom to avoid killing the runner before the coverage completes.
var REQUEST_ASYNC = !/PhantomJS/.test(window.navigator.userAgent);
function sendCoverage(callback) {
Object.keys(require.entries).forEach(function(file) {
// Only load non-test files from the project
Expand All @@ -16,7 +18,7 @@
var data = JSON.stringify(coverageData || {});

var request = new XMLHttpRequest();
request.open('POST', '/write-coverage', true);
request.open('POST', '/write-coverage', REQUEST_ASYNC);
request.setRequestHeader('Content-Type', 'application/json; charset=utf-8');
request.send(data);
request.responseType = 'json';
Expand Down