Skip to content

Installation and Upgrade Documentation - #1

Merged
pickypg merged 6 commits into
elastic:masterfrom
pickypg:feature/install-upgrade-1
Oct 25, 2016
Merged

Installation and Upgrade Documentation#1
pickypg merged 6 commits into
elastic:masterfrom
pickypg:feature/install-upgrade-1

Conversation

@pickypg

@pickypg pickypg commented Oct 24, 2016

Copy link
Copy Markdown
Member

This provides the cross-stack documentation for the Elastic Stack, by linking to the other repos and providing the required order for a low-impact upgrade.

/cc @dedemorton @debadair @nrichers

This provides the cross-stack documentation for the Elastic Stack, by linking to the other repos and providing the required order for a low-impact upgrade.
@pickypg

pickypg commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

/cc @ppf2 @eskibars @asawariS

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table should say "Component"

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table should say "Component"

@pickypg

pickypg commented Oct 24, 2016

Copy link
Copy Markdown
Member Author

Unsure if I should use "Component" versus "Product" everywhere.

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section IDs show up in URLs, so you should probably call this install-order-elastic-stack

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentence is a bit hard to parse. Maybe just say, "We recommend that you install the Elastic Stack in the following order." (When you talk about upgrading, then you mention that order is important.)

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Installing Elasticsearch.... (to be consistent).

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks installing the Elastic Stack for the first time need this info, too. I'd suggest moving the general overview content to an overview topic that introduces the Elastic Stack and describes what the guide covers. Then all users will benefit, and you won't have to worry about the order that you list the products in.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it over to the overview section.

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't read quite right (missing word). I'd suggest being more direct/less passive here. Maybe say: "To maintain the most compatibility, you must upgrade the stack in the recommended order."

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "The upgrade requires a full cluster shutdown for both Elasticsearch... (fixes unclear antecedent and typo)

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read this twice to parse it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded and dropped mentioning of Kibana.

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edit: "The following table lists the upgrade instructions and breaking changes for each component. Before upgrading, make sure you read through the upgrade guide and breaking changes list for every component that you are upgrading."

I wouldn't even say should.

@dedemorton

Copy link
Copy Markdown
Contributor

Added a few minor comments. Otherwise, LGTM.

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be just 2 columns here - Product and Installation?

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to both kind of goes against the flow. If I have to link to both, then that's okay, but I'd prefer to not have to distinguish between the installs.

Comment thread docs/installing-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are mentioning X-Pack in the previous table, maybe add a short statement on how Elastic Cloud will also install X-Pack for them?

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include Reporting here, for Reporting is 2.4.

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elasticsearch 1.x uses Lucene 4.x; Elasticsearch 2.x uses Lucene 5.x; and Elasticsearch 5.x uses Lucene 6.x. Lucene 6.x is not compatible with Lucene 4.x

Might be better to demonstrate this using a table with 3 columns, 1st column is Elasticsearch version, 2nd column is Lucene version, and 3rd column is Requires reindexing/Not compatible, etc..

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes simple indices

How about "includes system indices"

Comment thread docs/upgrading-stack.asciidoc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can link to https://www.elastic.co/guide/en/elasticsearch/reference/5.0/modules-snapshots.html#modules-snapshots which has a paragraph that talks about what to do with 1.x snapshots.

Comment thread docs/upgrading-stack.asciidoc Outdated

@ppf2 ppf2 Oct 25, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+4. Kibana

Which now includes Console (previously known as Sense) and Timelion

+5. X-Pack for Kibana (combines Marvel Agent, Shield, and Graph)

Add Reporting here.

Do we mean "Marvel", instead of "Marvel Agent" here?

@pickypg
pickypg merged commit 4a03723 into elastic:master Oct 25, 2016
@pickypg
pickypg deleted the feature/install-upgrade-1 branch October 25, 2016 02:57
@nellicus

Copy link
Copy Markdown

@pickypg just seen this https://www.elastic.co/guide/en/elastic-stack/5.1/upgrading-elastic-stack.html and loving it. kudos for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants