Skip to content

[9.5] [ML] Make Appex QA/PyTorch tests version-aware on release branches (#3115) - #3126

Merged
github-actions[bot] merged 1 commit into
9.5from
backport/9.5/pr-3115
Jul 28, 2026
Merged

[9.5] [ML] Make Appex QA/PyTorch tests version-aware on release branches (#3115)#3126
github-actions[bot] merged 1 commit into
9.5from
backport/9.5/pr-3115

Conversation

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.5:

Questions ?

Please refer to the Backport tool documentation

…3115)

The downstream appex-qa-stateful-custom-ml-cpp-build-testing pipeline
(elastic/qaf-tests) defaults to ES_BRANCH=main and STACK_VERSION=<current
main SNAPSHOT>, then downloads ml-cpp-<version>-SNAPSHOT-linux-x86_64.zip
from the parent build. On a release-branch / backport build the parent
produced ml-cpp-<release-version>-SNAPSHOT-... instead, so the download
missed ('No artifacts found') and the QA/PyTorch build failed spuriously
(e.g. a 9.5 backport looking for 9.6.0-SNAPSHOT).

Derive STACK_VERSION from gradle.properties (the exact artifact version)
and ES_BRANCH by comparing to ml-cpp main's version (main for the current
dev line, else major.minor), and forward both through the QA and PyTorch
downstream triggers. For main builds the derived values equal today's
defaults, so only release-branch/backport builds change behaviour. No
qaf-tests change is required; it already supports these overrides and lists
the active release branches/versions.

Co-authored-by: Cursor <cursoragent@cursor.com>
(cherry picked from commit 6c3df89)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: clean backport of an already-reviewed change. Auto-merge is armed and will merge once the required CI checks are green.

@github-actions
github-actions Bot enabled auto-merge (squash) July 27, 2026 23:03
@edsavage edsavage removed backport-pending auto-backport Automatically merge backport PRs when CI passes labels Jul 27, 2026
@edsavage

Copy link
Copy Markdown
Contributor

buildkite build

edsavage added a commit that referenced this pull request Jul 28, 2026
…alog-info (#3129)

The ml-cpp-pr-builds required status check 'buildkite/ml-cpp-pr-builds' is
produced by the pipeline's publish_commit_status setting. It was declared
false (with publish_commit_status_per_step true) in catalog-info.yaml, so the
Backstage sync kept resetting the pipeline to that — the required rollup was
never posted and PRs/backports stayed BLOCKED despite green builds (seen on
the #3115 backports #3125/#3126). Pipeline settings must be changed here, not
via the Buildkite API (the sync overwrites API changes).

Set publish_commit_status: true and publish_commit_status_per_step: false so
the single required rollup posts and per-step statuses don't flood PRs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
github-actions Bot merged commit 08b3834 into 9.5 Jul 28, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants