Made mortgage function - #1
Open
ejself wants to merge 1 commit into
Open
Conversation
sage-jordan
approved these changes
May 13, 2020
| function variableInterestRate(P, I, N) { | ||
| N = N*12; | ||
| I -= 0.02; | ||
| for(let i = 0; i < 10; i++){ |
Collaborator
There was a problem hiding this comment.
To iterate 10 times, should be i<10 because the count starts at 0
|
|
||
|
|
||
|
|
||
| function mortgageCalculator(principal, interestRate, years) { |
Collaborator
There was a problem hiding this comment.
you have years as a parameter but it's not being used. No need to take it in if it's not needed
Collaborator
|
You can merge after you look over these comments! :) |
Collaborator
|
And just "Resolve conversation" to mark them completed. Then, add/commit/push, then if you see your commit here, merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.