fix: skip specified Node.js version to set keep-alive #4527
Closed
rickyes wants to merge 1 commit intoeggjs:masterfrom
Closed
fix: skip specified Node.js version to set keep-alive #4527rickyes wants to merge 1 commit intoeggjs:masterfrom
rickyes wants to merge 1 commit intoeggjs:masterfrom
Conversation
…et Keep-Alive Header
atian25
reviewed
Nov 27, 2020
atian25
reviewed
Nov 27, 2020
| // Node.js >= 14.8.0 && < 14.12.0 and = 12.19.0 will set Keep-Alive Header | ||
| // Refs: https://github.com/nodejs/node/pull/34561 https://github.com/nodejs/node/pull/35138 | ||
|
|
||
| const shouldPatchKeepAliveHeader = !semver.satisfies(process.version, '>=14.8.0 <14.12.0 || =12.19.0'); |
Member
There was a problem hiding this comment.
这逻辑有问题吧，在 14.12.0 之上的版本，都不应该 patch 了，交给 Node 本身来 patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Related-issues have been fixed and released in Node.js v14.12.0 and v12.20.0
Refs: nodejs/node#34561 nodejs/node#35138