Created abstraction layer on top of qnx/linux config - #119
Open
armando-martins wants to merge 3 commits into
Open
Created abstraction layer on top of qnx/linux config#119armando-martins wants to merge 3 commits into
armando-martins wants to merge 3 commits into
Conversation
armando-martins
force-pushed
the
ajfm_separated_linux_qnx_configs
branch
4 times, most recently
from
August 13, 2026 14:47
c0d3da1 to
917279a
Compare
Now the "cc_toolchain_config" is not duplicated in both qnx and linux, and instead there is an abstraction layer that handles the general config, and the specific ones are still inside linux/qnx folder When adding a new OS, for example, we just need to create the specific folder with the "cc_toolchain_config.bzl.template", the needed flags and the BUILD file. Base "cc_toolchain_config" is now ready to not need changes in there when updating qnx/linux toolchain, or creating a new one.
armando-martins
force-pushed
the
ajfm_separated_linux_qnx_configs
branch
from
August 13, 2026 14:53
917279a to
13d1c73
Compare
Created a layer of abstraction with the flags that are common to all toolchains Inside linux and qnx folders we have only the specific ones. Common flags are sent to the specific toolchain via arguments of "make_features" and the specific ones are loaded directly inside specific toolchain
previously we were generating the config/flags for all the toolchains available in the project. Now we isolate each one of those, and the toolchain config/flags generated are now only the ones that are needed for a certain build, so when we run qnx toolchain, we dont generate the linux artifacts and vice versa.
armando-martins
marked this pull request as ready for review
August 14, 2026 10:03
armando-martins
requested review from
AlexanderLanin,
antonkri,
dcalavrezo-qorix and
nradakovic
as code owners
August 14, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the "cc_toolchain_config" is not duplicated in both qnx and linux, and instead there is an abstraction layer that handles the general config, and the specific ones are still inside linux/qnx folder
With this PR we can adapt our toolchain to new targets without make changes inside "templates/cc_toolchain_config.bzl.template" or "templates/cc_toolchain_flags.bzl.template", just needing to add the specific features and flags for that target, and adapt the "rules/gcc.bzl" to support the new one.