Skip to content

Normalize line endings in SSH key for the underlying OS#156

Merged
easingthemes merged 1 commit into
easingthemes:mainfrom
mansandersson:fix-key-line-endings
Sep 30, 2023
Merged

Normalize line endings in SSH key for the underlying OS#156
easingthemes merged 1 commit into
easingthemes:mainfrom
mansandersson:fix-key-line-endings

Conversation

@mansandersson

@mansandersson mansandersson commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

This fixes issue #143 on my side

This is my first ever nodejs commit so please help me out if I've done something completely unacceptable.

easingthemes
easingthemes requested changes Sep 24, 2023
View reviewed changes
Comment thread package.json Outdated
},
"homepage": "https://github.com/easingthemes/ssh-deploy#readme",
"dependencies": {
"os": "^0.1.2",

@easingthemes easingthemes Sep 24, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os is native nodeJS module, please remove it as a dependency

Comment thread src/sshKey.js
Comment thread package-lock.json

@easingthemes easingthemes Sep 24, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing dependencies there should be no changes to package.lock.

@easingthemes easingthemes mentioned this pull request Sep 24, 2023
Closed
@codespearhead

codespearhead commented Sep 24, 2023

Copy link
Copy Markdown
Collaborator

@mansandersson are you still willing to act on the changes and have this PR merged?

@easingthemes easingthemes mentioned this pull request Sep 24, 2023
Closed
@mansandersson

mansandersson commented Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

@mansandersson are you still willing to act on the changes and have this PR merged?

Yes, I'm willing to make the changes required

@codespearhead

codespearhead commented Sep 24, 2023

Copy link
Copy Markdown
Collaborator

@mansandersson are you still willing to act on the changes and have this PR merged?

Yes, I'm willing to make the changes required

Understood. Let me know if you need help! 😄

@easingthemes

easingthemes commented Sep 25, 2023

Copy link
Copy Markdown
Owner

Thanks.
Just one more: resolve conflicts in dist. Remove dist/index.js and rebuild it locally, then push new version.
Pleas use fix: some message in commit message so that release can be automatically triggered.

@mansandersson

mansandersson commented Sep 28, 2023

Copy link
Copy Markdown
Contributor Author

Thanks. Just one more: resolve conflicts in dist. Remove dist/index.js and rebuild it locally, then push new version. Pleas use fix: some message in commit message so that release can be automatically triggered.

Done. Let me know if anything else needs fixing.

@joebnb

joebnb commented Sep 30, 2023

Copy link
Copy Markdown

waiting for merging

@easingthemes easingthemes merged commit 448aa45 into easingthemes:main Sep 30, 2023
@easingthemes

easingthemes commented Sep 30, 2023

Copy link
Copy Markdown
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@easingthemes easingthemes easingthemes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mansandersson @codespearhead @easingthemes @joebnb