Fix divide by zero on hashrate calculation (sends nonce with zero hashrate) - #1767
Merged
revoxhere merged 1 commit intoMar 25, 2024
Merged
Conversation
revoxhere
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had issues with hashrate calculation causing divide by zero exceptions, and restarting the client connection. Tried to use nanoseconds to capture elapsed time, but still some hash calculations were very fast, resulting in the same exception.
Changed to logic to just send invalid data back, when the elapsed time is zero. While this results in a rejected response, it keeps the client connection active.
--
Obviously that, while trying to determine a good miner response message was for this scenario, I changed the hashrate calculation to report THs/s , and got a warning in my account :-) Hope this doesn't get me banned!