Skip to content

Fix completely broken ESP8266 miner (ver. 3.33) - #1586

Merged
revoxhere merged 1 commit into
duino-coin:masterfrom
Chupaka:patch-1
Dec 3, 2022
Merged

Fix completely broken ESP8266 miner (ver. 3.33)#1586
revoxhere merged 1 commit into
duino-coin:masterfrom
Chupaka:patch-1

Conversation

@Chupaka

@Chupaka Chupaka commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

And save last job difficulty for future use in dashboard

And save last job difficulty for future use in dashboard
@revoxhere

Copy link
Copy Markdown
Member

Can you provide more details?

@revoxhere revoxhere self-assigned this Dec 3, 2022
@Chupaka

Chupaka commented Dec 3, 2022

Copy link
Copy Markdown
Contributor Author

b54d33b this patch introduced MiningJob struct, and job parsing functionality was mainly moved there. But unsigned int difficulty = 0; global var is still here (not updated anymore), so for (unsigned int duco_numeric_result = 0; duco_numeric_result < difficulty; duco_numeric_result++) { never enters the loop body (as difficulty is now always zero). So, fixing that by using correct job.difficulty. But we can't remove difficulty var because it's used by web dashboard - so I still save last job parsing result to this var.

@revoxhere
revoxhere merged commit e3df560 into duino-coin:master Dec 3, 2022
@Chupaka
Chupaka deleted the patch-1 branch December 3, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants