Skip to content

302 Null plugin interface #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvar0hurtad0 wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from
Open

302 Null plugin interface #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Task/Collect/MethodCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ class MethodCollector {
* - 'description': The description from the method's docblock first line.
*/
public function collectMethods($name) {
if (!$name) {
Copy link
Copy Markdown
Contributor

@joachim-n joachim-n Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unrelated to #302 - I think you mentioned another bug you encountered. Do you remember how to reproduce it?

return [];
}

// Get a reflection class for the interface.
$reflection = new \ReflectionClass($name);
$methods = $reflection->getMethods();
Expand Down
2 changes: 1 addition & 1 deletion Task/Collect/PluginTypesCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ protected function addPluginBaseClass(&$data) {
*/
protected function analysePluginTypeBaseClassFromDefiningModule($data) {
// Bail if the interface doesn't have an 'Interface' suffix.
if (!preg_match('@Interface$@', $data['plugin_interface'])) {
if (!$data['plugin_interface'] || !preg_match('@Interface$@', $data['plugin_interface'])) {
return;
}

Expand Down