Skip to content

Fix issue 260 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhanu951 wants to merge 3 commits into
base: 4.2.x
Choose a base branch
from
Open

Fix issue 260 #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c45ae9d
Update PropertyDefinition.php
bhanu951 Aug 12, 2022
1dc58d6
Update PropertyDefinition.php
bhanu951 Aug 12, 2022
406acfd
Update DataItemArrayAccessTrait.php
bhanu951 Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions Definition/PropertyDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,22 +285,34 @@ public function loadLazyProperties() {
}
}

public function offsetExists($offset) {
/**
* {@inheritdoc}
*/
public function offsetExists(mixed $offset): bool {
dump($this);
throw new \Exception("Accessing definition $this->name as array with offsetExists $offset.");
}

public function offsetGet($offset) {
/**
* {@inheritdoc}
*/
public function offsetGet(mixed $offset): mixed {
dump($this);
throw new \Exception("Accessing definition $this->name as array with offsetGet $offset.");
}

public function offsetSet($offset, $value) {
/**
* {@inheritdoc}
*/
public function offsetSet(mixed $offset, mixed $value): void {
dump($this);
throw new \Exception("Accessing definition $this->name as array with offsetSet $offset.");
}

public function offsetUnset($offset){
/**
* {@inheritdoc}
*/
public function offsetUnset(mixed $offset): void {
dump($this);
throw new \Exception("Accessing definition $this->name as array with offsetUnset $offset.");
}
Expand Down
22 changes: 17 additions & 5 deletions MutableTypedData/Data/DataItemArrayAccessTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@
*/
trait DataItemArrayAccessTrait {

public function offsetExists($offset) {
/**
* {@inheritdoc}
*/
public function offsetExists(mixed $offset): bool {
return isset($this->value[$offset]);
}

public function offsetGet($offset) {
/**
* {@inheritdoc}
*/
public function offsetGet(mixed $offset): mixed {
if (!isset($this->properties[$offset])) {
throw new \Exception(sprintf("No property %s at address %s. Valid properties are: %s.",
$offset,
Expand Down Expand Up @@ -44,20 +50,26 @@ public function offsetGet($offset) {
}
}

public function offsetSet($offset, $value) {
/**
* {@inheritdoc}
*/
public function offsetSet(mixed $offset, mixed $value): void {
throw new \Exception(sprintf(
"Attempt to set array key %s at %s.",
$offset,
$this->getAddress()
));
}

public function offsetUnset($offset) {
/**
* {@inheritdoc}
*/
public function offsetUnset(mixed $offset): void {
throw new \Exception(sprintf(
"Attempt to unset array key %s at %s.",
$offset,
$this->getAddress()
));
}

}
}