GH-1063: Add is_update field to ActionCreatePreparedStatementResult (… - #32
Open
lriggs wants to merge 1 commit into
Open
GH-1063: Add is_update field to ActionCreatePreparedStatementResult (…#32lriggs wants to merge 1 commit into
lriggs wants to merge 1 commit into
Conversation
…sult (apache#1064) ## What's Changed A new field, `optional bool is_update = 4;`, was added to `message ActionCreatePreparedStatementResult`. When this field is sent by the server, its value indicates whether the proper network flow to execute the query that the driver should follow uses `CommandPreparedStatementQuery` or `CommandPreparedStatementUpdate`. For outdated servers that don't send the field, the driver maintains its current behavior of using `CommandPreparedStatementQuery` when the `dataset_schema` is not empty, thus ensuring the backward compatibility of the new driver with old servers. This change was created with AI assistance (Augment Code and Claude code). All lines were manually reviewed by a human. The output is not copyrightable subject matter. - Closes apache#1063 --------- Co-authored-by: David Li <li.davidm96@gmail.com>
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…apache#1064)
What's Changed
A new field,
optional bool is_update = 4;, was added tomessage ActionCreatePreparedStatementResult. When this field is sent by the server, its value indicates whether the proper network flow to execute the query that the driver should follow usesCommandPreparedStatementQueryorCommandPreparedStatementUpdate.For outdated servers that don't send the field, the driver maintains its current behavior of using
CommandPreparedStatementQuerywhen thedataset_schemais not empty, thus ensuring the backward compatibility of the new driver with old servers.This change was created with AI assistance (Augment Code and Claude code). All lines were manually reviewed by a human. The output is not copyrightable subject matter.
What's Changed
Please fill in a description of the changes here.
This contains breaking changes.
Closes #NNN.